ci: enforce shellcheck and shfmt #4926
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -0,0 +1,17 @@ | |||
| name: SH Checker | |||
Check notice
Code scanning / Checkov (reported by Codacy)
Ensure top-level permissions are not set to write-all Note
oklopfer
reviewed
Nov 23, 2023
| SHFMT_OPTS: -s -i 2 -bn -ci -sr -s | ||
| with: | ||
| sh_checker_comment: true | ||
| sh_checker_exclude: "packages/emacs/emacs.pacscript packages/emacs-git/emacs-git.pacscript" |
There was a problem hiding this comment.
is this list going to grow ever longer?
There was a problem hiding this comment.
Unless there is a specific request, no. We only added it because Wizard wanted some comments to be visually aligned.
oklopfer
previously approved these changes
Nov 25, 2023
|
this doesn't work yet Oren 💀 |
|
89b4ee8 |
|
It doesn't work if we remove it. I've tested it. |
|
ok what about this one https://github.com/koalaman/shellcheck-precommit |
|
and https://github.com/pecigonzalo/pre-commit-shfmt seems like they were just split out |
|
solved with #4965 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.